From f6131d432ec72db74bee15d61d2b047aa564f03c Mon Sep 17 00:00:00 2001
From: davidmonterocrespo24 <davidmonterocrespo24@gmail.com>
Date: Sun, 17 May 2026 05:26:12 +0200
Subject: [PATCH] fix(esp32 worker): importlib fallback for SignalRouter
 modules
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The esp32_worker.py subprocess is launched via `python <abs_path>`
and runs with a sys.path that does NOT include the backend/ package
root, so `from app.services.signal_router import SignalRouter`
raised ModuleNotFoundError at worker startup. The worker exited
with code 1 before QEMU even loaded, and the frontend surfaced the
generic "ESP32 crash detected — cache error" banner.

Mirror the existing esp32_flash_image fallback pattern (already in
this same file): try the package import first, fall back to
importlib.spec_from_file_location with the sibling .py path, then
publish the resulting module under its bare name in sys.modules so
typing references continue to work.

Verified: a synthetic test that strips backend/ from sys.path can
still construct a SignalRouter via the fallback. 20 unit tests in
test_signal_router.py still pass.
---
 backend/app/services/esp32_worker.py | 30 ++++++++++++++++++++++------
 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/backend/app/services/esp32_worker.py b/backend/app/services/esp32_worker.py
index 02d316f8..5b0b0a89 100644
--- a/backend/app/services/esp32_worker.py
+++ b/backend/app/services/esp32_worker.py
@@ -418,12 +418,30 @@ def main() -> None:  # noqa: C901  (complexity OK for inline worker)
     # The old `_ledc_gpio_map: dict[int, int]` (channel → gpio) has been
     # subsumed by the router's reverse index — call
     # `_signal_router.pins_for_signal(SIG_LEDC_*+channel)` instead.
-    from app.services.signal_router import SignalRouter  # noqa: E402
-    from app.services.esp32_signals import (  # noqa: E402
-        ledc_signal_for_channel,
-        SIG_LEDC_HS_CH0_OUT_IDX,
-        SIG_LEDC_LS_CH_LAST,
-    )
+    #
+    # `app.*` is not on sys.path inside this subprocess; mirror the same
+    # importlib fallback pattern used for esp32_flash_image (further down
+    # this file) so the worker can find its sibling modules without
+    # depending on the backend's package layout.
+    try:
+        from app.services.signal_router import SignalRouter  # type: ignore[import-not-found] # noqa: E402
+        from app.services.esp32_signals import (  # type: ignore[import-not-found] # noqa: E402
+            ledc_signal_for_channel,
+            SIG_LEDC_HS_CH0_OUT_IDX,
+            SIG_LEDC_LS_CH_LAST,
+        )
+    except ImportError:
+        import importlib.util as _ilu, pathlib as _pl
+        _here = _pl.Path(__file__).parent
+        for _name in ('signal_router', 'esp32_signals'):
+            _spec = _ilu.spec_from_file_location(_name, _here / f'{_name}.py')
+            _mod = _ilu.module_from_spec(_spec)  # type: ignore[arg-type]
+            _spec.loader.exec_module(_mod)        # type: ignore[union-attr]
+            sys.modules[_name] = _mod
+        SignalRouter = sys.modules['signal_router'].SignalRouter
+        ledc_signal_for_channel = sys.modules['esp32_signals'].ledc_signal_for_channel
+        SIG_LEDC_HS_CH0_OUT_IDX = sys.modules['esp32_signals'].SIG_LEDC_HS_CH0_OUT_IDX
+        SIG_LEDC_LS_CH_LAST = sys.modules['esp32_signals'].SIG_LEDC_LS_CH_LAST
     _signal_router = SignalRouter()
 
     def _refresh_signal_routing() -> None: