From 127b3f54f74a1abb8dd672a8edd1029566fb6469 Mon Sep 17 00:00:00 2001
From: David Montero <davidmonterocrespo24@gmail.com>
Date: Fri, 31 Jul 2026 21:51:22 +0200
Subject: [PATCH] docker: fetch the ESP32-S3 ROM (esp32s3_rev0_rom.bin)
 alongside the other ROMs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Self-hosted builds got 'qemu: -bios argument not set, and ROM code
binary not found' on any ESP32-S3 run because the ROM fetch loop only
knew the classic/C3 ROMs (issue #259, second half — the first half was
the drifted arm64 libqemu build, now republished for every platform).
---
 Dockerfile.standalone | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Dockerfile.standalone b/Dockerfile.standalone
index b0d23771..bff895a0 100644
--- a/Dockerfile.standalone
+++ b/Dockerfile.standalone
@@ -75,7 +75,7 @@ RUN cd /qemu \
         curl -fSL -o "$f" "${VELXIO_BINARY_BASE_URL}/${base}-${TARGETARCH}?key=${VELXIO_LICENSE_KEY}" ; \
       fi ; \
     done \
- && for f in esp32-v3-rom.bin esp32-v3-rom-app.bin esp32c3-rom.bin; do \
+ && for f in esp32-v3-rom.bin esp32-v3-rom-app.bin esp32c3-rom.bin esp32s3_rev0_rom.bin; do \
       asset="${f%.bin}" ; \
       if [ -f "$f" ]; then \
         echo "Using local $f ($(stat -c%s "$f") bytes)" ; \
@@ -238,6 +238,7 @@ RUN sed -i 's/\r$//' /app/entrypoint.sh && chmod +x /app/entrypoint.sh
 # libqemu-riscv32.so   → ESP32-C3 (RISC-V RV32IMC)
 # esp32-v3-rom*.bin    → boot/app ROM images required by esp32-picsimlab machine
 # esp32c3-rom.bin      → ROM image required by esp32c3-picsimlab machine
+# esp32s3_rev0_rom.bin → ROM image required by esp32s3-picsimlab machine
 # NOTE: ROM files must live in the same directory as the .so (worker passes -L
 #       to QEMU pointing at os.path.dirname(lib_path))
 RUN mkdir -p /app/lib